DYN-8942: Fix close on escape and autofocus for autocomplete, update search cache after async result.#16272
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8942
BogdanZavu
reviewed
Jun 5, 2025
| { | ||
| this.dynamoViewModel.UIDispatcher.BeginInvoke(() => | ||
| { | ||
| if (LastRequestGuid != myRequest || !IsOpen) return; |
Contributor
There was a problem hiding this comment.
Ah! You added this one as well. Nice!
BogdanZavu
approved these changes
Jun 5, 2025
Contributor
|
LGTM! |
Member
|
Ran the flaky test locally and it is working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix close on escape and autofocus for autocomplete, update search cache after async result.
2025-06-05.14-15-37.mp4
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fix close on escape and autofocus for autocomplete, update search cache after async result.
Reviewers
@johnpierson
@BogdanZavu
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of